Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove resubmit #650

Merged
merged 3 commits into from
Dec 15, 2023
Merged

Remove resubmit #650

merged 3 commits into from
Dec 15, 2023

Conversation

spirali
Copy link
Collaborator

@spirali spirali commented Dec 15, 2023

Removing resubmit + removes one extra copy of data

@spirali spirali requested a review from Kobzol December 15, 2023 14:33
Copy link
Collaborator

@Kobzol Kobzol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Feels great to finally remove this! 🎉 I left one nit + there's a clippy lint error.

CHANGELOG.md Outdated Show resolved Hide resolved
@spirali spirali merged commit fdc8772 into main Dec 15, 2023
12 of 14 checks passed
@spirali spirali deleted the remove-resubmit branch December 15, 2023 19:25
@Kobzol Kobzol added this to the v0.18 milestone Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants